Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert uncommenting auto detect schema in sync workflow #21614

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Jan 19, 2023

Reverting adding in Auto Detect Schema to SyncWorkflow, because JobPersistence needs to be removed from ConfigFetchActivityImpl and replaced with the JobsAPI in order to work in the data plane

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Jan 19, 2023
@alovew alovew temporarily deployed to more-secrets January 19, 2023 18:08 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 19, 2023 18:08 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 19, 2023 18:48 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 19, 2023 18:50 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

File Coverage [57.44%]
SyncWorkflowImpl.java 86.61% 🍏
ActivityBeanFactory.java 0%
Total Project Coverage 26.75% 🍏

@alovew alovew merged commit 0906ea8 into master Jan 19, 2023
@alovew alovew deleted the anne/revert-uncomment branch January 19, 2023 19:38
etsybaev pushed a commit that referenced this pull request Jan 19, 2023
* Revert uncommenting auto detect schema in sync workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants